Re: New VACUUM FULL

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

From: Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Jeff Davis <pgsql@j-davis.com>, Simon Riggs <simon@2ndQuadrant.com>, Alvaro Herrera <alvherre@commandprompt.com>, pgsql-hackers@postgresql.org

Date: 2009-12-07T07:55:26Z

Lists: pgsql-hackers

Attachments

vacuum-full_20091207a.patch (application/octet-stream) patch

Tom Lane <tgl@sss.pgh.pa.us> wrote:

> You should take those out again; if I am the committer I certainly will.
> Such a test will guarantee complete instability of every other
> regression test, and it's not worth it.

I read the original comment was saying to add regression tests for
database-wide vacuums. But I'll reduce the range of vacuum if they
are not acceptable.

The new patch contains only table-based vacuum for local tables and some of
system tables to test non-INPLACE vacuum are not used for system tables.
    VACUUM FULL pg_am;
    VACUUM FULL pg_class;
    VACUUM FULL pg_database;

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center