Re: enable-thread-safety defaults?
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter_e@gmx.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2009-11-30T17:21:20Z
Lists: pgsql-hackers
Attachments
- /pgpatches/thread (text/x-diff) patch
Magnus Hagander wrote: > 2009/11/24 Tom Lane <tgl@sss.pgh.pa.us>: > > Magnus Hagander <magnus@hagander.net> writes: > >> ISTM that it should be as simple as the attached patch. Seems to work > >> for me :-) But I'm no autoconf guru, so maybe I missed something? > > > > This patch sort of begs the question "what about enable-thread-safety-force?" > > That looks even more like a wart now than it did before. > > Agreed. But how about we try it piece-by-piece, which is we start with > this to see if it actually hits any of our bf platforms? Attached is a complete patch to enable threading of client libraries by default --- I think it is time (threading was added to PG 7.4 in 2003). I think we can guarantee that this will turn some build farm members red. How do we pass --disable-thread-safety to those hosts? The patch also removes --enable-thread-safety-force, which was added in 2004 for a platform that didn't have a thread-safe getpwuid(): http://archives.postgresql.org/pgsql-hackers/2004-07/msg00485.php I think we can just tell people they have to upgrade their operating systems if they want threading on those old platforms (or wait for complaints). -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +