Re: Application name patch - v3

On Wednesday 25 November 2009 14:28:14 Dave Page wrote:
> On Wed, Nov 25, 2009 at 1:22 PM, Andres Freund <andres@anarazel.de> wrote:
> > Hi,
> >
> > On Thursday 22 October 2009 15:07:13 Dave Page wrote:
> >> Updated patch attached. Per discussion, this:
> >>
> >> - Changes the envvar name to PGAPPNAME
> >> - Removes support for setting application_name in the startup packet,
> >> and instead sends an explicit SET command as part of the connection
> >> setup in PQconnectPoll. In order to avoid adding to the
> >> application-visible connection states, this is overloaded on the
> >> CONNECTION_SETENV state which is only used in the v2 protocol at
> >> present and seems like an ideal fit for such a similar use.
> >>
> >> Other features are as per the last version.
> >
> > One more question: Per my reading of the discussion (which very well
> > might be flawed), wasnt the plan to limit the availale characters in the
> > application name to ascii?
> 
> That was suggested, but I thought the eventual outcome was to not bother.
Then I dont see any reason to delay any further (sorry!). I personally would 
prefer making it a bit more strict but it surely is not imporant.

Markes as ready for comitter.

Andres