Re: Initial refactoring of plperl.c - draft [PATCH]

On Tue, Nov 24, 2009 at 11:57:06AM -0500, Tom Lane wrote:
> Tim Bunce <Tim.Bunce@pobox.com> writes:
> > The next step I plan is to move the large multi-line string literal
> > macros (PERLBOOT, SAFE_OK etc) into external perl code files.
> > That'll make refactoring, extending and maintaining that perl
> > code far simpler.
> 
> That does not seem like it accomplishes anything from the user's
> perspective except to add more points of failure.  To name just one:
> would you like to debug a problem that stems from a version mismatch
> between plperl.so and the external perl files?  I wouldn't.
> 
> I can see wanting the *source* to be separate files, but having it as a
> compiled constant string in the executable seems like the right thing.
> 
> Since this language is obviously going to require Perl to be present at
> compile time, running a little Perl script to convert the source into a
> C literal wouldn't be a problem AFAICS.

Okay, thanks. I'll take that route.

Tim.