Re: plperl and inline functions -- first draft
Joshua Tolley <eggyknap@gmail.com>
From: Joshua Tolley <eggyknap@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@postgresql.org
Date: 2009-11-07T02:37:35Z
Lists: pgsql-hackers
Attachments
- plperl-inline.patch (text/x-diff) patch
On Fri, Nov 06, 2009 at 06:37:38PM -0500, Andrew Dunstan wrote: > > I wrote: >> >> Ok, I have a handle on the trusted/nontrusted issue. But I think the >> piece that's missing here is that it needs to save the calling context >> etc. and use PG_TRY() and friends, just like plperl_call_handler(). >> I'll work on that. >> >> > > OK, I committed the previously discussed change to store the language > trusted flag in the InlineCodeBlock structure. Following that, here is > my reworking of Josh's patch for DO blocks for plperl. > > Missing are docs and regression tests. Attached is a cleaned up comment with documentation. I looked through the regression tests and didn't find any that used plperl -- should we add one for this (or for this and all kinds of other stuff)? Is there some way to make running the regression test conditional on having built --with-perl in the first place? -- Joshua Tolley / eggyknap End Point Corporation http://www.endpoint.com