Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Jim Cox <shakahshakah@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@commandprompt.com>, pgsql-hackers@postgresql.org, Peter Eisentraut <peter_e@gmx.net>, David Fetter <david@fetter.org>
Date: 2009-10-02T22:18:56Z
Lists: pgsql-hackers
Jim Cox wrote: > On Fri, Oct 2, 2009 at 6:11 PM, Bruce Momjian <bruce@momjian.us> wrote: > > Tom Lane wrote: > >> Bruce Momjian <bruce@momjian.us> writes: > >> > Are we sure we don't want a date/time in the ASCII dump? ?It would > >> > affect database diffs, but I can see it useful too. > >> > >> We used to have one, and it was removed by popular demand > >> (or actually demoted to be printed only in verbose mode, IIRC). > >> I don't feel a need to revisit that decision. > > > > OK, thanks, I had forgotten. > > > > To Tom's point, the patch only outputs the new info in verbose mode, > and in that mode a timestamp is indeed already output (it is the > subsequent line in the ASCII dump, actually). Thank you. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +