Re: CommitFest 2009-09, two weeks on
Alvaro Herrera <alvherre@commandprompt.com>
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Michael Meskes <meskes@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org, Hans-Juergen Schoenig <hs@cybertec.at>, Dan Colish <dan@unencrypted.org>
Date: 2009-10-01T15:02:03Z
Lists: pgsql-hackers
Boszormenyi Zoltan escribió: > First, Tom Lane suggested to unify core and ecpg FETCH > syntaxes so both will accept optional FROM/IN, which I did. > SQLDA support adds new FETCH forms (Informix-specific > ones) so naturally these patches clash. There's no simple way > to make they separately applicable. With the first version, > the same technical dependency were also there, because of > the (already explained) grammar problem, I got 2 shift/reduce > problems in the FETCH/MOVE stmts unless I de-factorized > FORWARD and BACKWARD out of fetch_direction. > The new FETCH forms with SQLDA touched the same areas > in ecpg.addon. Probably the parts that touch the core grammar can be reviewed and applied separately. -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.