Re: [PATCH 5/6] psql: print_aligned_text uses table formatting

Alvaro Herrera <alvherre@commandprompt.com>

From: Alvaro Herrera <alvherre@commandprompt.com>
To: Roger Leigh <rleigh@codelibre.net>
Cc: Roger Leigh <rleigh@debian.org>, pgsql-hackers@postgresql.org
Date: 2009-08-23T22:29:12Z
Lists: pgsql-hackers
Roger Leigh wrote:
> On Sun, Aug 23, 2009 at 11:47:02AM -0400, Alvaro Herrera wrote:

> > Wouldn't it be better to do a single fprintf call here instead of
> > fputc + fputs?
> 
> It's certainly possible to change it; the above might be slightly more
> efficient than a call to fprintf since you skip parsing the format
> string, but otherwise I have no real preference for one over the
> other.

There are already other fprintf calls in the same function -- I wouldn't
worry too much about some hypothetical performance gain.  Let's keep
things simple and readable.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.