Re: Idea for minor tstore optimization
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Neil Conway <neilc@samurai.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2008-03-22T23:47:12Z
Lists: pgsql-hackers
Added to TODO: * Avoid tuple some tuple copying in sort routines http://archives.postgresql.org/pgsql-hackers/2008-02/msg01206.php --------------------------------------------------------------------------- Tom Lane wrote: > Neil Conway <neilc@samurai.com> writes: > > I notice that several of the call sites of tuplestore_puttuple() start > > with arrays of datums and nulls, call heap_form_tuple(), and then switch > > into the tstore's context and call tuplestore_puttuple(), which > > deep-copies the HeapTuple into the tstore. ISTM it would be faster and > > simpler to provide a tuplestore_putvalues(), which just takes the datum > > + nulls arrays and avoids the additional copy. > > Seems reasonable. Check whether tuplesort should offer the same, while > you are at it. > > regards, tom lane > > ---------------------------(end of broadcast)--------------------------- > TIP 1: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://postgres.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +