Horton

Re: What to do with inline warnings?

Martijn van Oosterhout <kleptog@svana.org>

View thread View on postgr.es
From: Martijn van Oosterhout <kleptog@svana.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers@postgresql.org
Date: 2008-05-14T17:31:33Z
Lists: pgsql-hackers 
On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote:
> > tqual.c: In function ‘HeapTupleSatisfiesVacuum’:
> > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
> > tqual.c:1057: error: called from here
> > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
> > tqual.c:1061: error: called from here
> 
> Hmm, it's a bit disturbing that the compiler is taking it upon itself to
> decide that these calls are "unlikely".

Perhaps would should give it some idea about how likely they'd be,
because clearly it has no idea now.

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while 
> boarding. Thank you for flying nlogn airlines.