Re: Is this a bug in pg_current_logfile() on Windows?

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

Cc: Thomas Kellerer <shammat@gmx.net>, pgsql-hackers@lists.postgresql.org

Date: 2020-07-09T21:39:40Z

Lists: pgsql-hackers, pgsql-general

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 7/9/20 3:36 PM, Tom Lane wrote:
>> Should we consider back-patching the CRLF filtering changes, ie
>> 91bdf499b + ffb4cee43?  It's not really necessary perhaps, but
>> I dislike situations where the "same" test on different branches is
>> testing different things.  Seems like a recipe for future surprises.

> Yes please.

Done.

			regards, tom lane

Commits

Tighten up Windows CRLF conversion in our TAP test scripts.
- d0390509a182 9.5.23 landed
- ce9d053423fd 9.6.19 landed
- a3cfb10764bb 12.4 landed
- 89162b7364bf 11.9 landed
- 4c17c5a8529c 10.14 landed
- 17b87b3049fa 13.0 landed
- 91bdf499b37b 14.0 landed
Fix pg_current_logfile() to not emit a carriage return on Windows.
- 90b418f81645 11.9 landed
- 765ad260a18f 10.14 landed
- 601d419b2b5d 13.0 landed
- 2564e2d08546 12.4 landed
- 183926da3162 14.0 landed
Further tighten Windows CRLF conversion in our TAP test scripts.
- ffb4cee43bdc 14.0 landed
Add test coverage for pg_current_logfile() function.
- 1c4e88e2fe41 14.0 landed
Fix failures to ignore \r when reading Windows-style newlines.
- b654714f9bcf 13.0 cited
Fix TAP infrastructure to support Mingw better
- 33f3bbc6d37d 10.0 cited