Re: CREATE SCHEMA ... CREATE DOMAIN support
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: jian he <jian.universality@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-28T05:52:54Z
Lists: pgsql-hackers
Kirill Reshke <reshkekirill@gmail.com> writes: > On Wed, 27 Nov 2024 at 23:39, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> We've fixed a few utility statements so that they can receive >> a passed-down ParseState, but not DefineDomain. > PFA as an independent patch then. Or should we combine these two into one? No, I don't think this should be part of the patch discussed in this thread. It feels rather random to me to be fixing only DefineDomain; I'm sure there's more in the same vein. I'd like to see a patch with a scope along the lines of "fix everything reachable within CREATE SCHEMA" or perhaps "fix all calls of typenameType". (A quick grep shows that an outright majority of the callers of that are passing null ParseState. I didn't look to see if any of them have a good excuse beyond "we didn't do the plumbing work".) regards, tom lane
Commits
-
Don't try to re-order the subcommands of CREATE SCHEMA.
- a9c350d9ee66 19 (unreleased) landed
-
Execute foreign key constraints in CREATE SCHEMA at the end.
- 404db8f9edbb 19 (unreleased) landed
-
Support more object types within CREATE SCHEMA.
- d516974840f4 19 (unreleased) landed