Re: pgsql: Extract catalog info for error reporting before an error actually
Alvaro Herrera <alvherre@commandprompt.com>
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-committers@postgresql.org, Hackers <pgsql-hackers@postgresql.org>
Date: 2007-10-25T16:41:50Z
Lists: pgsql-hackers
Simon Riggs wrote: > On Thu, 2007-10-25 at 14:45 +0000, Alvaro Herrera wrote: > > Log Message: > > ----------- > > Extract catalog info for error reporting before an error actually happens. > > Also, remove redundant reset of for-wraparound PGPROC flag. > > Just noticed you've made these changes. I was working on them, but > hadn't fully tested the patch because of all the different touch points. > Sorry for the delay. > > Would you like me to refresh my earlier patch against the newly > committed state (or did you commit that aspect already as well?). I am doing just that. I'll post it soon. FWIW I disagree with cancelling just any autovac work automatically; in my patch I'm only cancelling if it's analyze, on the grounds that if you have really bad luck you can potentially lose a lot of work that vacuum did. We can relax this restriction when we have cancellable vacuum. -- Alvaro Herrera http://www.flickr.com/photos/alvherre/ "La principal característica humana es la tontería" (Augusto Monterroso)