Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, Bernd Helmle <mailings@oopsware.de>, Alvaro Herrera <alvherre@commandprompt.com>, Andrew Geery <andrew.geery@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-10-15T14:27:20Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Catalog NOT NULL constraints

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Oct 15, 2010 at 4:06 AM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>> If these were the only problems with this patch, given that they
>> required only trivial changes to initialise variables to NIL/false,
>> perhaps it was premature to mark it as "returned with feedback".

> Sure.  Is someone available to do a detailed code review?  Alvaro,
> were you planning to pick this one up?

I had been planning to take this one once it got past initial review,
since it was mostly my wish to start with.

			regards, tom lane