Re: [HACKERS] slow information schema with thausand users, seq.scan
Bruce Momjian <pgman@candle.pha.pa.us>
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: andrew@supernews.com, Peter Eisentraut <peter_e@gmx.net>, PostgreSQL-patches <pgsql-patches@postgresql.org>
Date: 2006-02-12T19:32:12Z
Lists: pgsql-hackers
Attachments
- (unnamed) (text/plain)
I have remove the LEFT part of the join to pg_roles in psql/description.c. I assume this is too risky for 8.1.X. --------------------------------------------------------------------------- Tom Lane wrote: > Andrew - Supernews <andrew+nonews@supernews.com> writes: > > On 2006-02-06, Peter Eisentraut <peter_e@gmx.net> wrote: > >> It already has indexes. > > > True, but they're not being used where you'd expect. This seems to be > > something to do with the fact that it's not pg_authid which is being > > accessed, but rather the view pg_roles. > > I looked into this and it seems the problem is that the view doesn't > get flattened into the main query because of the has_nullable_targetlist > limitation in prepjointree.c. That's triggered because pg_roles has > '********'::text AS rolpassword > which isn't nullable, meaning it would produce wrong behavior if > referenced above the outer join. > > Ultimately, the reason this is a problem is that the planner deals only > in simple Vars while processing joins; it doesn't want to think about > expressions. I'm starting to think that it may be time to fix this, > because I've run into several related restrictions lately, but it seems > like a nontrivial project. > > In the meantime, reducing the LEFT JOIN to pg_roles to a JOIN as per > Peter's suggestion seems like the best short-term workaround. > > regards, tom lane > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Have you searched our list archives? > > http://archives.postgresql.org > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073