Horton

Re: Re-thing PG_MODULE_MAGIC

Martijn van Oosterhout <kleptog@svana.org>

View thread
From: Martijn van Oosterhout <kleptog@svana.org>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, josh@agliodbs.com, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Date: 2006-06-16T08:27:44Z
Lists: pgsql-hackers 
On Fri, Jun 16, 2006 at 12:01:53AM -0400, Bruce Momjian wrote:
> OK, new text:
> 
> 	The <quote>magic block</> required in all PostgreSQL-supported libraries
> 	is checked to guarantee compatibility.  For this reason, non-PostgreSQL
> 	libraries cannot be loaded in this way.

Heh. "guarantee"? We only check four things and it's possible to change
the system in all sorts of subtle ways (--integer-datetimes) that won't
be picked up. Ofcourse, for 99% of modules this is not a problem but
I'm not sure if the word "guarantee" is appropriate.

Maybe just "checked for compatibility", or "determine" or "ascertain".

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.