Re: Re-thing PG_MODULE_MAGIC
Bruce Momjian <pgman@candle.pha.pa.us>
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: josh@agliodbs.com, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Date: 2006-06-16T04:01:53Z
Lists: pgsql-hackers
Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > Josh Berkus wrote: > >>> The <quote>magic block</> present in all PostgreSQL-supported libraries > >>> is checked to guarantee compatibility. For this reason, non-PostgreSQL > >>> libraries cannot be loaded in this way. > >> > >> you need "must be" before "present". > > > Uh, the point is not that they need a magic block (though they do), but > > rather that the magic block is always checked. > > It's a grammar complaint, not a factual complaint. Personally I'd > suggest wording it as "the magic block required in all ..." OK, new text: The <quote>magic block</> required in all PostgreSQL-supported libraries is checked to guarantee compatibility. For this reason, non-PostgreSQL libraries cannot be loaded in this way. -- Bruce Momjian http://candle.pha.pa.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +