Re-thing PG_MODULE_MAGIC

Josh Berkus <josh@agliodbs.com>

From: Josh Berkus <josh@agliodbs.com>
To: pgsql-hackers@postgresql.org
Date: 2006-06-14T23:54:00Z
Lists: pgsql-hackers
Hey,

I just noticed (the hard way) that in 8.2CVS, the PG_MODULE_MAGIC header is 
now *required* for all loadable modules.   This includes non-pg modules, 
such as Solaris' libumem (performance improvement for malloc).

FATAL:  incompatible library "/usr/lib/libumem.so": missing magic block
HINT:  Extension libraries are now required to use the  
PG_MODULE_MAGIC macro.

Should we really be requiring PG_MODULE_MAGIC for stuff that wasn't built 
with PG?   This seems like a way to break a lot of people's software.

-- 
--Josh

Josh Berkus
PostgreSQL @ Sun
San Francisco