Re: [HACKERS] 8.0 libpq: missing get_home_path()
Bruce Momjian <pgman@candle.pha.pa.us>
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Karel Zak <zakkr@zf.jcu.cz>, PostgreSQL-patches <pgsql-patches@postgresql.org>
Date: 2004-08-19T00:01:19Z
Lists: pgsql-hackers
Attachments
- (unnamed) (text/plain)
OK, patch attached and applied. I also updated the docs.
---------------------------------------------------------------------------
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I need to call canonicalize_path() in the macro.
>
> There is only one use of get_home_path in libpq. Lose it and do
> a direct getenv(HOMEDIR). You do not really need to do a
> canonicalize_path there; it'd be sufficient to insert the appropriate
> directory separator ('/' or '\') when forming pgpassfile just below.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073