Use of 'cp -r' in CREATE DATABASE
Bruce Momjian <pgman@candle.pha.pa.us>
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Date: 2003-12-11T23:36:05Z
Lists: pgsql-hackers
Our dbcommands.c has for create database:
snprintf(buf, sizeof(buf), "cp -r '%s' '%s'", src_loc, target_dir);
but my BSD/OS manual only documents 'cp -R' and mentions:
Historic versions of the cp utility had a -r option. This implementation
supports that option, however, its use is strongly discouraged, as it
does not correctly copy special files, symbolic links or fifo's.
I think we should switch to -R in our code.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073