Re: Autocomplete <TAB> on Postgres7.4beta5 not working?

Bruce Momjian <pgman@candle.pha.pa.us>

From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Gaetano Mendola <mendola@bigfoot.com>, pgsql-bugs@postgresql.org, pgsql-hackers@postgresql.org, Ian Barwick <barwick@gmx.net>
Date: 2003-10-28T22:05:22Z
Lists: pgsql-bugs, pgsql-hackers
Tom Lane wrote:
> This appears to have been a deliberate change:
> 
> 2003-03-27 11:45  momjian
> 
> 	* src/bin/psql/tab-complete.c: Attached are two patches for psql's
> 	tab-completion.c.
>         [snip]
> 
> 	Note that tables, indexes, views and sequences relations in the
> 	'pg_catalog' namespace are excluded even though they are in the
> 	current search path. I found not doing this produced annoying
> 	behaviour when expanding names beginning with 'p'. People who work
> 	with system tables a lot may not like this though; I can look for
> 	another solution if necessary.
> 	
> 	Ian Barwick
> 
> AFAICT there was no discussion about this issue when the patch was
> proposed and applied.  But now that the point is raised I have to say
> that I don't like this change.  I don't think system catalogs should be
> excluded from tab completion.  They never were before 7.4, and I have
> not seen anyone complaining about that, other than Ian.
> 
> Comments anyone?

No one commented on it so it was applied --- now that we have two people
who don't like it, seems we should back it out.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073