Re: Call for port reports

Peter Eisentraut wrote:
> Peter Eisentraut writes:
> 
> > FreeBSD 4.8-RELEASE alpha
> >
> > BUT: The default CFLAGS are set by configure to -O2, although the template
> > wants -O.  I manually modified the CFLAGS to -O after configure.
> 
> I've committed a fix for the CFLAGS handling, and now this platform works
> perfectly.

Your approach looks good.  You decided to allow template to set the
CFLAGS, and if it doesn't, make it -O2/-O.  That is a very clean
approach.

I had the idea of layering the flags so template would only _add_ to
CFLAGS, but your way is clearer.

One other idea would be to set CFLAGS to "" before including template,
and just test to see if it is still "" after --- that might be cleaner
than saving the original value and comparing.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073