Horton
Menu

Re: move 0 behaviour

Bruce Momjian <pgman@candle.pha.pa.us>

View thread
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2002-11-03T01:21:11Z
Lists: pgsql-hackers, pgsql-general 
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >>> I thought about that, but I need to fail if the cursor name is invalid. 
> >> 
> >> What has that got to do with it?
> 
> > If I put the 'return' for 0 MOVE/FETCH in utility.c's FetchStmt code, I
> > will not get the checks for invalid cursor names, and I will not get the
> > proper return tag.
> 
> Oh, I see.  Yeah, you're probably right, we have to change the calling
> convention for PerformPortalFetch.
> 
> BTW, portalcmds.h also contains a comment that would need to be fixed.

Updated.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073