Re: COPY FROM is not 8bit clean
Bruce Momjian <pgman@candle.pha.pa.us>
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Darcy Buskermolen <darcy@ok-connect.com>, Tatsuo Ishii <t-ishii@sra.co.jp>, pgsql-bugs@postgresql.org, pgsql-hackers@postgresql.org
Date: 2002-02-27T03:09:32Z
Lists: pgsql-bugs, pgsql-hackers
Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > Can someone explain why this fixes the problem. > > Think about a machine where char is signed by default. Extracting \254 > into an int will produce -2, which will not equal \254 returned by getc. Oh, I thought that the int returned by getc already had that sign extension, but now I remember it doesn't. In fact, it specifically returns an int so -1 can be identified. Got it. Seems I am forgetting some of my C. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026