Horton

Re: COPY FROM is not 8bit clean

Tatsuo Ishii <t-ishii@sra.co.jp>

View thread
From: Tatsuo Ishii <t-ishii@sra.co.jp>
To: darcy@ok-connect.com
Cc: pgsql-bugs@postgresql.org, pgsql-hackers@postgresql.org
Date: 2002-02-26T12:16:54Z
Lists: pgsql-bugs, pgsql-hackers 
> When useing COPY FROM 'file' DELIMITER '\254' copyfrom reads past the
> delimiter and ends up with parse errors when trying to do the insert
> 
> 
> What the ?? why dind' tthat go through with the body of the text.. *sigh*
> I'll resend in the AM.. 

Good catch. It's definitely a bug in copy command. Please try
following patches (this is against 7.2).

*** src/backend/commands/copy.c.orig	Tue Feb 26 21:11:05 2002
--- src/backend/commands/copy.c	Tue Feb 26 21:11:35 2002
***************
*** 1024,1030 ****
  CopyReadAttribute(FILE *fp, bool *isnull, char *delim, int *newline, char *null_print)
  {
  	int			c;
! 	int			delimc = delim[0];
  
  #ifdef MULTIBYTE
  	int			mblen;
--- 1024,1030 ----
  CopyReadAttribute(FILE *fp, bool *isnull, char *delim, int *newline, char *null_print)
  {
  	int			c;
! 	int			delimc = (unsigned char)delim[0];
  
  #ifdef MULTIBYTE
  	int			mblen;