Re: @(#)Mordred Labs advisory 0x0003: Buffer overflow in PostgreSQL

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Neil Conway wrote:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
> > Neil Conway <neilc@samurai.com> writes:
> > > + 	/* Check for integer overflow */
> > > + 	if (tlen / slen != count)
> > > + 		elog(ERROR, "Requested buffer is too large.");
> > 
> > What about slen == 0?
> 
> Good point -- that wouldn't cause incorrect results or a security
> problem, but it would reject input that we should really accept.
> 
> Revised patch is attached.
> 
> Cheers,
> 
> Neil
> 
> -- 
> Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073