Re: pgindent run?
Bruce Momjian <pgman@candle.pha.pa.us>
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Hiroshi Inoue <Inoue@tpf.co.jp>
Cc: Alfred Perlstein <bright@wintelcom.net>, Tom Lane <tgl@sss.pgh.pa.us>, The Hermit Hacker <scrappy@hub.org>, Peter Eisentraut <peter_e@gmx.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2001-03-23T04:51:18Z
Lists: pgsql-hackers
> Bruce Momjian wrote: > > > > You don't notice the value of pgindent until you have some code that > > hasn't been run through it. For example, ODBC was not run through until > > this release, and I had a terrible time trying to understand the code > > because it didn't _look_ like the rest of the code. Now that pgindent > > is run, it looks more normal, and I am sure that will encourage more > > people to get in and make changes. > > > > I see now the following comment in interfaces/odbc/statement.c. > Though it's mine(probably), it's hard for me to read. > Please tell me how to prevent pgindent from changing > comments. > > /* > * Basically we don't have to begin a transaction in autocommit mode > * because Postgres backend runs in autocomit mode. We issue "BEGIN" > * in the following cases. 1) we use declare/fetch and the statement > * is SELECT (because declare/fetch must be called in a transaction). > * 2) we are in autocommit off state and the statement isn't of type > * OTHER. > */ Sorry that happened. It is mentioned in the developer's FAQ that the dashes prevent wrapping. I know it is hard to remember even if you know it, and I would be glad to fix any comments that look bad. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026