Horton

Re: beta6 pg_restore core dumps

Martin Renters <martin@datafax.com>

View thread
From: Martin Renters <martin@datafax.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tatsuo Ishii <t-ishii@sra.co.jp>, Martin Renters <martin@datafax.com>, Philip Warner <pjw@rhyme.com.au>, pgsql-hackers@postgresql.org
Date: 2001-03-19T15:40:56Z
Lists: pgsql-hackers 
On Sat, Mar 17, 2001 at 12:31:20PM -0500, Tom Lane wrote:
> After looking more closely I see that pg_restore has two different
> buffer overrun conditions in this one routine.  Attached is take two
> of my patch.
> 
> This would be a lot simpler and cleaner if _PrintData() simply didn't
> append a zero byte to the buffer contents.  Philip, is it actually
> necessary for it to do that?

This patch seems to fix the problem I was seeing.

Martin