Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > First, here is a patch which will prevent this from happening in the
> > future.  Do people want this held for 7.2 or applied now?  It disables
> > the creation of user indexes on system tables.
>   
> > + 	if (heapRelationName && !allow_system_table_mods &&
> > + 		IsSystemRelationName(heapRelationName) && IsNormalProcessingMode())
> > + 	{
> > + 		elog(ERROR, "You can not create indexes on system tables:  '%s'",
> > + 			 heapRelationName);
> > + 	}
> > + 
> 
> I think it would be a real good idea to put in this safeguard, but
> I don't much like that error message.  How about
> 
>     elog(ERROR, "User-defined indexes on system catalogs are not supported");

Change made to patch.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026