Re: compute_query_id and pg_stat_statements
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>,
Fujii Masao <masao.fujii@oss.nttdata.com>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-25T17:17:03Z
Lists: pgsql-hackers
Julien Rouhaud <rjuju123@gmail.com> writes: > On Sun, Apr 25, 2021 at 11:39:55AM -0400, Tom Lane wrote: >> I agree repeated warnings would be bad news. I was wondering if we could >> arrange a single warning at the time pg_stat_statements is preloaded into >> the postmaster. In this way, if you tried to use a configuration file >> that used to work, you'd hopefully get some notice about why it no longer >> does what you want. Also, if you are preloading pg_stat_statements, it >> seems reasonable to assume that you'd like the global value of the flag >> to be "on", even if there are use-cases for transiently disabling it. > What about people who wants to use pg_stat_statements but are not ok with our > query_id heuristics and use a third-party plugin for that? They're still going to want the GUC set to something other than "off", no? In any case it's just a one-time log message, so it's not likely to be *that* annoying. regards, tom lane
Commits
-
Allow compute_query_id to be set to 'auto' and make it default
- cafde58b337e 14.0 landed
-
Move pg_stat_statements query jumbling to core.
- 5fd9dfa5f50e 14.0 cited