Re: Re: NetBSD/Alpha and PostgreSQL-current [was Re: NetBSD/Alpha and rkirkpat's patch]

Tatsuo Ishii <t-ishii@sra.co.jp>

From: Tatsuo Ishii <t-ishii@sra.co.jp>
To: tgl@sss.pgh.pa.us
Cc: tom@minnesota.com, pgsql-bugs@postgresql.org, brent@rcfile.org, pgsql@rkirkpat.net, a.joubert@albourne.com, arrigo@albourne.com
Date: 2000-12-31T03:23:33Z
Lists: pgsql-bugs, pgsql-general
> Hmm, do you have an environment definition for PGPORT?
> 
> I notice that pg_regress.sh contains
> 
> 	export PGPORT
> 
> but it doesn't necessarily set any value for PGPORT.  It seems possible
> that some shells may take this as license to invent an empty-string
> value for PGPORT, which would cause libpq to think that port 0 is being
> specified.
> 
> My feeling is that libpq ought to ignore an empty-string PGPORT
> environment value, rather than treat it as selecting port 0.
> Comments anyone?

Agreed. I have already committed changes to ignore empty-string pgport
paramter of PQsetdbLogin(). Same thing should be applied to PGPORT
environment variable too, I think.
--
Tatsuo Ishii