Thread

  1. SSL support

    Mikhail Teterin <mi@privatelabs.com> — 2000-10-06T15:30:21Z

    It appears,  the following patch  is needed to  ensure the 7.0.2  can be
    built  with SSL  support (with  OpenSSL). It  fixes the  fe-connect.c to
    report errors in "the new way". A few Makefiles also need to be modified
    to ensure the SSL libraries are listed as dependencies for the PG libs.
    
    
    --- interfaces/libpq/fe-connect.c	Sun May 21 17:19:53 2000
    +++ interfaces/libpq/fe-connect.c	Fri Sep 15 13:53:52 2000
    @@ -801 +801 @@
    -			sprintf(conn->errorMessage,
    +			printfPQExpBuffer(&conn->errorMessage,
    @@ -809 +809 @@
    -			sprintf(conn->errorMessage, "PQconnectDB() -- couldn't read postmaster response: errno=%d\n%s\n",
    +			printfPQExpBuffer(&conn->errorMessage, "PQconnectDB() -- couldn't read postmaster response: errno=%d\n%s\n",
    @@ -822 +822 @@
    -					sprintf(conn->errorMessage,
    +					printfPQExpBuffer(&conn->errorMessage,
    @@ -832 +832 @@
    -				sprintf(conn->errorMessage,
    +				printfPQExpBuffer(&conn->errorMessage,
    @@ -850 +850 @@
    -			strcpy(conn->errorMessage,
    +			printfPQExpBuffer(&conn->errorMessage,
    --- interfaces/libpq/fe-connect.c	Sun May 21 17:19:53 2000
    +++ interfaces/libpq/fe-connect.c	Fri Sep 15 13:53:52 2000
    @@ -801 +801 @@
    -			sprintf(conn->errorMessage,
    +			printfPQExpBuffer(&conn->errorMessage,
    @@ -809 +809 @@
    -			sprintf(conn->errorMessage, "PQconnectDB() -- couldn't read postmaster response: errno=%d\n%s\n",
    +			printfPQExpBuffer(&conn->errorMessage, "PQconnectDB() -- couldn't read postmaster response: errno=%d\n%s\n",
    @@ -822 +822 @@
    -					sprintf(conn->errorMessage,
    +					printfPQExpBuffer(&conn->errorMessage,
    @@ -832 +832 @@
    -				sprintf(conn->errorMessage,
    +				printfPQExpBuffer(&conn->errorMessage,
    @@ -850 +850 @@
    -			strcpy(conn->errorMessage,
    +			printfPQExpBuffer(&conn->errorMessage,
    
    
  2. Re: SSL support

    Bruce Momjian <pgman@candle.pha.pa.us> — 2000-10-10T02:43:26Z

    It appears this had already been done in the current sources.
    
    > It appears,  the following patch  is needed to  ensure the 7.0.2  can be
    > built  with SSL  support (with  OpenSSL). It  fixes the  fe-connect.c to
    > report errors in "the new way". A few Makefiles also need to be modified
    > to ensure the SSL libraries are listed as dependencies for the PG libs.
    > 
    > 
    > --- interfaces/libpq/fe-connect.c	Sun May 21 17:19:53 2000
    > +++ interfaces/libpq/fe-connect.c	Fri Sep 15 13:53:52 2000
    > @@ -801 +801 @@
    > -			sprintf(conn->errorMessage,
    > +			printfPQExpBuffer(&conn->errorMessage,
    > @@ -809 +809 @@
    > -			sprintf(conn->errorMessage, "PQconnectDB() -- couldn't read postmaster response: errno=%d\n%s\n",
    > +			printfPQExpBuffer(&conn->errorMessage, "PQconnectDB() -- couldn't read postmaster response: errno=%d\n%s\n",
    > @@ -822 +822 @@
    > -					sprintf(conn->errorMessage,
    > +					printfPQExpBuffer(&conn->errorMessage,
    > @@ -832 +832 @@
    > -				sprintf(conn->errorMessage,
    > +				printfPQExpBuffer(&conn->errorMessage,
    > @@ -850 +850 @@
    > -			strcpy(conn->errorMessage,
    > +			printfPQExpBuffer(&conn->errorMessage,
    > --- interfaces/libpq/fe-connect.c	Sun May 21 17:19:53 2000
    > +++ interfaces/libpq/fe-connect.c	Fri Sep 15 13:53:52 2000
    > @@ -801 +801 @@
    > -			sprintf(conn->errorMessage,
    > +			printfPQExpBuffer(&conn->errorMessage,
    > @@ -809 +809 @@
    > -			sprintf(conn->errorMessage, "PQconnectDB() -- couldn't read postmaster response: errno=%d\n%s\n",
    > +			printfPQExpBuffer(&conn->errorMessage, "PQconnectDB() -- couldn't read postmaster response: errno=%d\n%s\n",
    > @@ -822 +822 @@
    > -					sprintf(conn->errorMessage,
    > +					printfPQExpBuffer(&conn->errorMessage,
    > @@ -832 +832 @@
    > -				sprintf(conn->errorMessage,
    > +				printfPQExpBuffer(&conn->errorMessage,
    > @@ -850 +850 @@
    > -			strcpy(conn->errorMessage,
    > +			printfPQExpBuffer(&conn->errorMessage,
    > 
    
    
    -- 
      Bruce Momjian                        |  http://candle.pha.pa.us
      pgman@candle.pha.pa.us               |  (610) 853-3000
      +  If your life is a hard drive,     |  830 Blythe Avenue
      +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026