Re: config.h (was Re: Misc. consequences of backend memory management changes)

Brook Milligan <brook@biology.nmsu.edu>

From: Brook Milligan <brook@biology.nmsu.edu>
To: tgl@sss.pgh.pa.us
Cc: peter_e@gmx.net, pgsql-hackers@postgreSQL.org
Date: 2000-06-30T14:56:26Z
Lists: pgsql-hackers
   One thing that does occur to me is that a very large fraction of
   config.h is now symbols that are supposed to be set by configure,
   and as you say it's not good to give people the idea that they
   should tweak those results by hand after configuring.  What do you
   think of pulling the remaining hand-settable symbols out into a
   separate file, maybe called something like "siteconfig.h"?  Then
   config.h becomes purely a machine-generated file.  This would
   also solve the problem of losing hand-set config choices if you
   rerun configure.

config.h should contain only machine generated stuff for exactly the
reasons you mention.  Perhaps config.h.in should be something like:

/* siteconfig.h overrides various variables */
#include "siteconfig.h"

/* enable feature FOO (can be overridden by siteconfig.h) */
#ifndef FOO
#undefine FOO
#endif

Cheers,
Brook