Horton

Thread

Commits

  1. Remove unused argument of ATAddForeignConstraint

  2. Fix creation of duplicate foreign keys on partitions

  1. useless argument of ATAddForeignKeyConstraint

    Amit Langote <langote_amit_f8@lab.ntt.co.jp> — 2019-02-14T09:47:42Z

    Hi,

While reviewing the foreign keys referencing partitioned tables patch, I
noticed that the parentConstr argument of ATAddForeignConstraint is
rendered useless by the following commit:

commit 0325d7a5957ba39a0dce90835ab54a08ab8bf762
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:   Fri Jan 18 14:49:40 2019 -0300

    Fix creation of duplicate foreign keys on partitions

Above commit added another function specialized for recursively adding a
given foreign key constraint to partitions, so ATAddForeignConstraint is
no longer called recursively.

Maybe remove that argument in HEAD ?  Attached a patch.

Thanks,
Amit

  2. Re: useless argument of ATAddForeignKeyConstraint

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2021-05-05T16:33:39Z

    On 2019-Feb-14, Amit Langote wrote:

> While reviewing the foreign keys referencing partitioned tables patch, I
> noticed that the parentConstr argument of ATAddForeignConstraint is
> rendered useless by the following commit:

> Maybe remove that argument in HEAD ?  Attached a patch.

Indeed -- two years later this is still valid, so applied, with thanks!

-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)