Re: pg_upgrade test chatter
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: "Bossart, Nathan" <bossartn@amazon.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-10-20T02:08:52Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes: > On 2021-Oct-19, Tom Lane wrote: >> We could dodge that, with modern versions of psql, by issuing >> two -c switches. > Isn't it easier to pass client_min_messages via PGOPTIONS? > PGOPTIONS="-c client_min_messages=warning" psql -c "drop database if exists foo" Yeah, my original thought had been to hack this at the test level. However, I felt like it'd be worth adding this code because we could apply it elsewhere in pg_regress.c to save several psql sessions (and hence backend starts) per regression DB creation. That's not a huge win, but it'd add up. regards, tom lane
Commits
-
Improve pg_regress.c's infrastructure for issuing psql commands.
- f45dc59a38ca 15.0 landed