Re: "postmaster became multithreaded" is reachable
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-01-23T18:51:32Z
Lists: pgsql-hackers
Noah Misch <noah@leadboat.com> writes: > On Thu, Jan 23, 2025 at 01:22:13PM -0500, Tom Lane wrote: >> An alternative idea (that maybe should also be done in PostmasterMain) >> is to report the HINT only #ifdef __darwin__ and on other platforms >> use the "Please report a bug" text. > I gather pthread_is_threaded_np() is still macOS-only, in which case the > !darwin branch would be future-proofing only. Ah, I had not realized that. Perhaps the comments about this code should mention that? > Another alternative would be to track whether we reached the startup-time > check, emitting a message at exit only if we did reach the startup-time check. > If a postmaster passes the startup-time check and fails the exit-time check, > changing the environment won't help. Even so, I'm content with your first > proposal. Yeah, seems like overcomplication. Let's go with the simple way. regards, tom lane
Commits
-
Don't ask for bug reports about pthread_is_threaded_np() != 0.
- 63644c15d74e 13.19 landed
- 63a4b9f76786 14.16 landed
- 4d6e169c4341 15.11 landed
- 7ab181a29ba5 16.7 landed
- 6c9a83f216a0 17.3 landed
- 4f15759bdcdd 18.0 landed