Horton

Re: table AM option passing

Antonin Houska <ah@cybertec.at>

View thread View on postgr.es
From: Antonin Houska <ah@cybertec.at>
To: alvherre@kurilemu.de
Cc: Chao Li <li.evan.chao@gmail.com>, Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@lists.postgresql.org>, Zsolt Parragi <zsolt.parragi@percona.com>, Nathan Bossart <nathandbossart@gmail.com>
Date: 2026-04-01T15:16:58Z
Lists: pgsql-hackers 
Álvaro Herrera <alvherre@kurilemu.de> wrote:

> Hmm, this is actually a problem in 1bd6f22f43ac.  I added a preliminary
> patch that should fix this.

I've reviewed this patch set too. The only question that occurs to me is
whether INSERT_SKIP_FSM and INSERT_FROZEN shouldn't actually be prefixed with
HEAP_, as these are rather low-level and thus might be considered
AM-specific.

(I like the idea to use the high bits to avoid collisions.)

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

Commits

  1. Give an 'options' parameter to tuple_delete/_update

  2. Fix vicinity of tuple_insert to use uint32, not int, for options

  3. Have table_insert and siblings use an unsigned type for options

  4. Remove the following unused type definitions: bool8, bool16, bool32, word8,