Horton
Menu

Re: testing HS/SR - 1 vs 2 performance

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Erik Rijkers <er@xs4all.nl>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2010-04-27T17:52:50Z
Lists: pgsql-hackers 
Simon Riggs <simon@2ndQuadrant.com> writes:
> v3 attached

This patch changes KnownAssignedXidsRemove() so that failure to find
the target XID is elog(ERROR) (ie, a PANIC, since this is in the
startup process).  However, this comment is still there:

	/*
	 * We can fail to find an xid if the xid came from a subtransaction that
	 * aborts, though the xid hadn't yet been reported and no WAL records have
	 * been written using the subxid. In that case the abort record will
	 * contain that subxid and we haven't seen it before.
	 */

WTF?  Either the comment is wrong or this should not be an elog
condition.

			regards, tom lane