Horton

Re: On login trigger: take three

a.sokolov@postgrespro.ru

View thread View on postgr.es
From: a.sokolov@postgrespro.ru
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Greg Nancarrow <gregn4422@gmail.com>, Ivan Panchenko <wao@mail.ru>, Teodor Sigaev <teodor@sigaev.ru>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, vignesh C <vignesh21@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2022-03-28T12:57:37Z
Lists: pgsql-hackers 
Daniel Gustafsson писал 2022-03-22 11:43:
>> On 22 Mar 2022, at 04:48, Andres Freund <andres@anarazel.de> wrote:
> 
>> docs fail to build: 
>> https://cirrus-ci.com/task/5556234047717376?logs=docs_build#L349
> 
> Ugh, that one was on me and not the original author. Fixed.
> 

+    data initialization. It is vital that any event trigger using the
+    <literal>login</literal> event checks whether or not the database 
is in
+    recovery.

Does any trigger really have to contain a pg_is_in_recovery() call? In 
this message 
(https://www.postgresql.org/message-id/20220312024652.lvgehszwke4hhove%40alap3.anarazel.de) 
it was only about triggers on hot standby, which run not read-only 
queries

-- 
Andrey Sokolov
Postgres Professional: http://www.postgrespro.com

Commits

  1. Fix some typos in event trigger docs

  2. Use heap_inplace_update() to unset pg_database.dathasloginevt

  3. Remove the flaky check in event_trigger_login regression test

  4. Fix instable 006_login_trigger.pl test

  5. Add support event triggers on authenticated login

  6. Add GUC for temporarily disabling event triggers

  7. Fix typo in reference to __FreeBSD__.

  8. Restore robustness of TAP tests that wait for postmaster restart.

  9. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.