Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Euler Taveira <euler.taveira@2ndquadrant.com>,
PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
Maciek Sakrejda <m.sakrejda@gmail.com>
Date: 2020-06-22T15:49:40Z
Lists: pgsql-bugs
Julien Rouhaud <rjuju123@gmail.com> writes:
> On Sun, Jun 21, 2020 at 4:29 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> 2. Text-format EXPLAIN output will grow double-quotes around the
>> hypothetical index names, which are not there at present (I believe,
>> but didn't test it). This shouldn't bother human users particularly,
>> but conceivably it might break hypopg's regression tests?
> Yes, the patch is working as expected. Before:
> ...
> All of the regression tests except the one I added when the fix for
> brin hypothetical indexes was applied are still working, as they're
> looking for patterns like "Index.*<\d+>${amname}_${relname}" in the
> textual explain output. There are a few fixes not released yet, so
> I'll update the broken brin regression test and publish a release soon
> to make sure that the packages don't get broken when the new minor
> versions are released.
Doesn't sound too painful then. I pushed the patch to all branches;
it should appear in 13beta2 this week, and in the August quarterly
updates.
regards, tom lane
Commits
-
Undo double-quoting of index names in non-text EXPLAIN output formats.
- dda25c599fcf 9.5.23 landed
- d3d8755180b6 12.4 landed
- bd53ea2b270f 9.6.19 landed
- 6d9f7a094ca7 10.14 landed
- 63d2ac23b018 14.0 landed
- 57f8b9913b91 13.0 landed
- 35a8e227e6c6 11.9 landed