Horton
Menu

Re: walreceiver is uninterruptible on win32

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@gmail.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Joe Conway <mail@joeconway.com>
Date: 2010-04-15T02:17:39Z
Lists: pgsql-hackers 
Magnus Hagander <magnus@hagander.net> writes:
> Looking at the call-sites, there are bugs now - if PQexec() returns
> NULL, we don't deal with it. It also doesn't always free the result
> properly. I've added checks for that.

I think you're just adding useless complexity there.  PQresultStatus
defends itself just fine against a NULL input, and most other libpq
functions likewise.

			regards, tom lane