Re: Removing --disable-strong-random from the code

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2018-12-30T16:56:48Z
Lists: pgsql-hackers
I wrote:
> LGTM otherwise.

Oh, one more thought: the removal of the --disable-strong-random
documentation stanza means there's no explanation of what to do
to build on platforms without /dev/urandom.  Perhaps something
like this in installation.sgml:

      <para>
-      You need <productname>OpenSSL</productname>, if you want to support
-      encrypted client connections. The minimum required version is
-      0.9.8.
+      You need <productname>OpenSSL</productname> if you want to support
+      encrypted client connections.  <productname>OpenSSL</productname>
+      is also required for random number generation on platforms that
+      do not have <filename>/dev/urandom</filename> (except Windows).
+      The minimum required version is 0.9.8.
      </para>

			regards, tom lane


Commits

  1. Remove configure switch --disable-strong-random

  2. Fix generation of padding message before encrypting Elgamal in pgcrypto