Re: Should we remove -Wdeclaration-after-statement?

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Andres Freund <andres@anarazel.de>

Cc: Robert Haas <robertmhaas@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, Jelte Fennema-Nio <postgres@jeltef.nl>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, "ranier.vf@gmail.com" <ranier.vf@gmail.com>, chap@anastigmatix.net

Date: 2024-01-29T22:09:23Z

Lists: pgsql-hackers

Andres Freund <andres@anarazel.de> writes:
> On 2024-01-29 15:01:06 -0500, Robert Haas wrote:
>> And it still baffles me why we allow everyone to pick their own system for
>> capitalizing identifiers out of a hat, without even insisting on consistency
>> from one end of the same identifier to the other.

> Yes. Please. I hate some capitalization/underscore styles, but I hate spending
> time feeling out which capitalization style I should use so much more.  Let's
> at least define some minimal naming guidelines for new code.

I'm for this for entirely-new code, but I think when adding code in
existing modules we're better off with the rule of "make it match
nearby code".  I admit it might be hard to draw a clear line between
the two cases, plus there might be local inconsistency already.
But let's try to avoid making local style inconsistencies worse.

			regards, tom lane