Horton

Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Michael Paquier <michael@paquier.xyz>, Greg Sabino Mullane <htamfids@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>, Jelte Fennema-Nio <postgres@jeltef.nl>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-06-13T13:57:42Z
Lists: pgsql-hackers 
On 13.06.25 04:56, Michael Paquier wrote:
> On Thu, Jun 12, 2025 at 09:53:13PM -0400, Greg Sabino Mullane wrote:
>> On Thu, Jun 12, 2025 at 9:14 AM Peter Eisentraut <peter@eisentraut.org>
>> wrote:
>>> And this is not something users ever see, so the connection would not be
>>> obvious.  Maybe this should be called something more specific like
>>> \close_stmt.
>>
>> Maybe just \closeprepared ?
> 
> I'm OK with a rename if people feel strongly about it and we still
> have the time to do tweaks like that, but I don't like the suggestions
> \close_stmt and \closeprepared, because that's inconsistent with the
> other new meta-commands.
> 
> What about \close_named to be consistent with \bind_named?  We always
> require a statement name when closing a prepared statement.

That doesn't address the concern that it's confusing what kind of object 
\close operates on.  There are named and unnamed cursors (= portals), 
after all.

Commits

  1. psql: Rename meta-command \close to \close_prepared

  2. psql: Add tests for repeated calls of \bind[_named]

  3. psql: Fix memory leak with repeated calls of \bind

  4. psql: Clean up more aggressively state of \bind[_named], \parse and \close

  5. psql: Add more meta-commands able to use the extended protocol

  6. psql: Add ignore_slash_options in bind's inactive branch