Horton

Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgreSQL.org
Date: 2018-10-09T21:39:09Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> On 2018-10-09 17:27:17 -0400, Tom Lane wrote:
>> I complained about this already on the other thread, I think, but:
>> I do not think we should remove timeofday().  It's unrelated to these
>> datatypes and it offers functionality that isn't quite duplicated
>> elsewhere.

> Ok.  I find it a somewhat weird function, but I agree it's not strongly
> related. It only came up because it's implemented in nabstime.c.  Moving
> it to utils/adt/timestamp.c seems to make the most sense?

Sure, if you want to flush nabstime.c completely, just shove it over
there.

			regards, tom lane

Commits

  1. Clean up/tighten up coercibility checks in opr_sanity regression test.

  2. Remove abstime, reltime, tinterval tables from old regression databases.