Horton

Re: doc: add missing "id" attributes to extension packaging page

Brar Piening <brar@gmx.de>

View thread View on postgr.es
From: Brar Piening <brar@gmx.de>
To: "Karl O. Pinc" <kop@karlpinc.com>
Cc: Corey Huinker <corey.huinker@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, vignesh C <vignesh21@gmail.com>, Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-24T05:48:17Z
Lists: pgsql-hackers 
On 24.03.2023 at 05:09, Karl O. Pinc wrote:
> Hi Brar,
>
> An observation:  The # that shows up when hovering
> over section-level headings is styled as the
> section-level heading is.  But the # that shows
> up when hovering over varlistentrys has the default
> text style.
>
> This works for me.  It's nice to have the "section #"s
> look like the section heading.  But the varlistentry's
> terms are smaller than the normal font, and their
> line width is less heavy than normal.  I'm not really
> invested one way or the other, but I find it kind of
> nice that the varlistentry's #s are easier to click
> on and more noticable because they're slightly larger
> than might be expected.

TBH I didn't bother a lot with this.

Most of the time it's actually not the font size but rather the
font-family which gets inherited from the parent element if you don't
set it explicitly.

The link just inherits everithing (including the color, which I have set
to inherit explicitly since links don't inherit the parent's color by
default) from it's parent, which is the HTML <dt> element (ultimately
the inheritance probably goes up to the <body> element style in pretty
much all cases).

In some instances the input <term> element contains elements that are
styled differently in the output (e.g.: <literal> which translates to
HTML <code> which has "font-family: monospace;") which makes the # from
the link appear differently than the visible element it appears after.

Since (after tweaking the color) the general visual appearence looked ok
to me, I didn't bother with this any further.

Regards,

Brar

Commits

  1. doc: Make HTML ids discoverable

  2. Add missing XML ID attribute

  3. postgres_fdw: Add support for parallel abort.

  4. Add missing XML ID attributes

  5. Add XML ID attributes to create_subscription.sgml.

  6. Stop recommending auto-download of DTD files, and indeed disable it.

  7. Doc: add XML ID attributes to <sectN> and <varlistentry> tags.

  8. Allow left join removals and unique joins on partitioned tables

  9. Improve GIN cost estimation