Horton

Re: Add privileges test for pg_stat_statements to improve coverage

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: kuroda.keisuke@nttcom.co.jp
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@postgresql.org
Date: 2024-07-23T18:27:15Z
Lists: pgsql-hackers

Attachments


On 2024/07/23 15:02, kuroda.keisuke@nttcom.co.jp wrote:
> Hi Fujii-san,
> Thank you for your comment!
> 
> attach v5 fixed patch.
> 
>> Using "postgres" as the default superuser name can cause instability.
>> This is why the Patch Tester reports now test failures again.
>> You should create and use a different superuser, such as
>> "regress_stats_superuser."
> 
> I understand.
> Add "regress_stats_superuser" for test by superuser.

Thanks for updating the patch!

I've slightly modified the comments in the regression tests for clarity.
Attached is the v6 patch. If there are no objections,
I will push this version.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. pg_stat_statements: Add regression test for privilege handling.