Horton

Re: Built-in CTYPE provider

Daniel Verite <daniel@manitou-mail.org>

View thread View on postgr.es
From: "Daniel Verite" <daniel@manitou-mail.org>
To: "Noah Misch" <noah@leadboat.com>
Cc: Jeff Davis <pgsql@j-davis.com>, Peter Eisentraut <peter@eisentraut.org>, Jeremy Schneider <schneider@ardentperf.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-07-18T11:29:27Z
Lists: pgsql-hackers 
	Noah Misch wrote:

> If I'm counting the votes right, you and Tom have voted that the feature's
> current state is okay, and I and Laurenz have voted that it's not okay.  I
> still hope more people will vote, to avoid dealing with the tie.  Daniel,
> Peter, and Jeremy, you're all listed as reviewers on commit f69319f.  Are
> you
> willing to vote one way or the other on the question in
> https://postgr.es/m/20240706195129.fd@rfd.leadboat.com?

For me, the current state is okay.

In the mentioned question, you're doing this:

  v17 can simulate the Unicode aspect of a v18 upgrade, like this:
    sed -i 's/^UNICODE_VERSION.*/UNICODE_VERSION = 16.0.0/'
src/Makefile.global.in

to force a Unicode upgrade. But a packager could do the same
to force a Unicode downgrade, if they wanted.

Therefore I don't agree with this summary in
<20240711125040.11.nmisch@google.com>:

>                                  | ICU collations    | pg_c_utf8
> ----------------------------------|-------------------|----------
> Corruption within a major version | packager's choice | no
> Corruption at pg_upgrade time     | packager's choice | yes



Best regards,
-- 
Daniel Vérité
https://postgresql.verite.pro/
Twitter: @DanielVerite

Commits

  1. Support PG_UNICODE_FAST locale in the builtin collation provider.

  2. Support Unicode full case mapping and conversion.

  3. Fix test failures when language environment is not UTF-8.

  4. Add unicode_strtitle() for Unicode Default Case Conversion.

  5. Use version for builtin collations.

  6. Fix convert_case(), introduced in 5c40364dd6.

  7. Inline basic UTF-8 functions.

  8. Support C.UTF-8 locale in the new builtin collation provider.

  9. Fix another warning, introduced by 846311051e.

  10. Address more review comments on commit 2d819a08a1.

  11. Fix unreachable code warning from commit 2d819a08a1.

  12. Introduce "builtin" collation provider.

  13. Catalog changes preparing for builtin collation provider.

  14. Unicode case mapping tables and functions.

  15. Add Unicode property tables.

  16. Documentation update for Standard Collations.

  17. Cleanup for unicode-update build target and test.

  18. Shrink Unicode category table.

  19. Make some error strings more generic

  20. pg_upgrade: copy locale and encoding information to new cluster.

  21. Update Unicode data to Unicode 15.0.0

  22. Create a new type category for "internal use" types.