Thread

Commits

  1. Make some comments use the term "ProcSignal" for consistency

  1. consistently use "ProcSignal" instead of "procsignal" in code comments

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2021-11-05T05:52:27Z

    Hi,
    
    I see that "procsignal" and "ProcSignal" are being used in the code
    comments which look inconsistent. IMO, "ProcSignal" is the right word
    to use and let's be consistent across the code comments. Attaching a
    tiny patch for that.
    
    Thoughts?
    
    Regards,
    Bharath Rupireddy.
    
  2. Re: consistently use "ProcSignal" instead of "procsignal" in code comments

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-11-09T03:51:39Z

    
    On 2021/11/05 14:52, Bharath Rupireddy wrote:
    > Hi,
    > 
    > I see that "procsignal" and "ProcSignal" are being used in the code
    > comments which look inconsistent. IMO, "ProcSignal" is the right word
    > to use and let's be consistent across the code comments. Attaching a
    > tiny patch for that.
    > 
    > Thoughts?
    
    I'm fine with this. Barring any objection, I will commit the patch.
    
    Regards,
    
    -- 
    Fujii Masao
    Advanced Computing Technology Center
    Research and Development Headquarters
    NTT DATA CORPORATION
    
    
    
    
  3. Re: consistently use "ProcSignal" instead of "procsignal" in code comments

    Michael Paquier <michael@paquier.xyz> — 2021-11-09T04:01:41Z

    On Tue, Nov 09, 2021 at 12:51:39PM +0900, Fujii Masao wrote:
    > I'm fine with this. Barring any objection, I will commit the patch.
    
    I have to admit that the timing is kind of odd, or strange, or both,
    because I was just going through my backlog from -hackers, and just
    bumped on this thread like 15 minutes ago..  And the patch was fine on
    consistency ground, so I have just applied it now.
    --
    Michael
    
  4. Re: consistently use "ProcSignal" instead of "procsignal" in code comments

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2021-11-09T04:03:58Z

    
    On 2021/11/09 13:01, Michael Paquier wrote:
    > On Tue, Nov 09, 2021 at 12:51:39PM +0900, Fujii Masao wrote:
    >> I'm fine with this. Barring any objection, I will commit the patch.
    > 
    > I have to admit that the timing is kind of odd, or strange, or both,
    > because I was just going through my backlog from -hackers, and just
    > bumped on this thread like 15 minutes ago..
    
    :)
    
    
    >  And the patch was fine on
    > consistency ground, so I have just applied it now.
    
    Thanks!
    
    Regards,
    
    -- 
    Fujii Masao
    Advanced Computing Technology Center
    Research and Development Headquarters
    NTT DATA CORPORATION