Horton

Re: relation OID in ReorderBufferToastReplace error message

Jeremy Schneider <schnjere@amazon.com>

View thread View on postgr.es
From: Jeremy Schneider <schnjere@amazon.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>, "Drouvot, Bertrand" <bdrouvot@amazon.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Andres Freund <andres@anarazel.de>
Date: 2021-09-21T20:47:54Z
Lists: pgsql-hackers 
On 9/20/21 22:14, Amit Kapila wrote:
> On Fri, Sep 17, 2021 at 10:53 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> I don't think it is a bad idea to print additional information as you
>> are suggesting but why only for this error? It could be useful to
>> investigate any other error we get during decoding. I think normally
>> we add such additional information via error_context. We have recently
>> added/enhanced it for apply-workers, see commit [1].
>>
>> I think here we should just print the relation name in the error
>> message you pointed out and then work on adding additional information
>> via error context as a separate patch. What do you think?
> 
> Attached please find the patch which just modifies the current error
> message as proposed by you. I am planning to commit it in a day or two
> unless there are comments or any other suggestions.

Looks good to me. I see that I hadn't used the macro for getting the
relation name, thanks for fixing that!

-Jeremy


-- 
Jeremy Schneider
Database Engineer
Amazon Web Services

Commits

  1. Back-patch "Add parent table name in an error in reorderbuffer.c."

  2. Add parent table name in an error in reorderbuffer.c.

  3. Fix reorder buffer memory accounting for toast changes.

  4. Add logical change details to logical replication worker errcontext.

  5. Fix toast rewrites in logical decoding.

  6. Add error codes to some corruption log messages